irctk

commit 33dfa3d19b10c495173a3bc1f1601777c4a2d325
parent 42f7494bef2fb47ae2909e02694b4b6c20dfec43
Author: Antoine Amarilli <a3nm@a3nm.net>
Date:   Sat, 28 Jul 2012 01:26:47 +0200

update todos

Diffstat:
TODO
 | 
3
++-
irctk.c
 | 
12
++++--------

2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/TODO b/TODO
@@ -27,7 +27,8 @@ last-active and reply:
 - last-goes then last-said until \n
 - stack on things to manage with \n as delimiter
 
-
+other:
+- don't block if stdout block, use a fifo with a thread
 
 
 Future features:
diff --git a/irctk.c b/irctk.c
@@ -167,7 +167,7 @@ struct arguments
   int port;
   char *password;
   char **channels;
-  int n_channels; // TODO reconcile this with fifos
+  int n_channels; // TODO2 refactor this with fifos
 
   int verbosity;
 
@@ -788,7 +788,7 @@ void push_fifo_set(fifo_set *s, char *fl, char *dests, char *l) {
   post_push(s, was_empty);
 }
 
-/* TODO refactor */
+/* TODO2 refactor this */
 void push_fifo_set_all(fifo_set *s, char *fl, char **dests, int ndests, char *l) {
   pre_push(s);
   int was_empty;
@@ -900,7 +900,6 @@ int pop_fifo_set(fifo_set *s, action **result) {
 // fifo for input
 // we want to read lines at the time we get them even if we are delaying writes
 // on the irc channel
-/* TODO fifo_out for output to avoid blocking if stdout blocks */
 fifo_set fifos;
 
 
@@ -1017,7 +1016,7 @@ int do_cmd_msg(irc_session_t *s, char *chan, char* line)
 
   debug("do_cmd_msg %s %s\n", chan, line);
 
-  /* TODOponey ask the server to notify, if possible */
+  /* TODO2 ask the server to notify, if possible */
   /* TODO2 find a way to get real host name (part after !) */
   
   if (line[0] == '/' && args.command_to_event) {
@@ -1081,7 +1080,7 @@ int do_cmd_msg(irc_session_t *s, char *chan, char* line)
     } else {
       info("Unrecognized or malformed command: %s", line);
     }
-    // TODO: names, list, topic, usermode, whois, raw...
+    // TODO2: names, list, topic, usermode, whois, raw...
     // with correct user tracking!
   } else {
     /* TODO2 only join channels we haven't joined yet */
@@ -1204,7 +1203,6 @@ void cmd_msg(char *full_line, char *target, char *line)
            args.last_chans_out[0] ? args.last_chans_out : first_chan(), line);
 
       case DEFAULT_ALL:
-        //TODO also for chans joined at runtime?
         //TODO2: ugly, could have generated the comma-separated string
         //like for last_chans_out!
         return push_fifo_set_all(&fifos, full_line, args.channels, args.n_channels, line);
@@ -1385,7 +1383,6 @@ void event_ctcp_action (irc_session_t *session, const char *event,
     const char *origin, const char **params, unsigned int count) 
 {
   saw_user(origin);
-  //TODO where is the channel?!
   if (args.event_to == COMMAND)
     mprintf("[%s] <%s> /me %s\n", params[0], output_nick(origin), params[1]);
   if (args.event_to == MESSAGE)
@@ -1398,7 +1395,6 @@ void event_kick (irc_session_t *session, const char *event, const char *origin,
 {
   saw_user(origin);
   saw_user(params[1]);
-  // TODO check for optional params
   if (args.event_to == COMMAND)
     mprintf("[%s] <%s> /kick %s %s\n", params[0], output_nick(origin), params[1], params[2]);
   if (args.event_to == MESSAGE)